Skip to content

initial commit#1

Merged
UmanShahzad merged 10 commits intomasterfrom
umar/initial-implementation
May 12, 2023
Merged

initial commit#1
UmanShahzad merged 10 commits intomasterfrom
umar/initial-implementation

Conversation

@rm-Umar
Copy link
Copy Markdown
Contributor

@rm-Umar rm-Umar commented May 10, 2023

No description provided.

@rm-Umar rm-Umar requested a review from UmanShahzad May 10, 2023 08:51
Copy link
Copy Markdown
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdullahdevrel can you check out the README.md file here as well?

Comment thread setup.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread ipinfodb/client.py Outdated
Comment thread ipinfodb/client.py Outdated
Comment thread ipinfodb/client.py Outdated
Comment thread ipinfodb/client.py Outdated
Comment thread ipinfodb/client.py Outdated
@abdullahdevrel
Copy link
Copy Markdown
Contributor

@rm-Umar @UmanShahzad Everything looks good to me. I will create the docs and GIFs for it in the community.

Do we have a linear ticket for the project? I will create a child ticket for myself.

@abdullahdevrel abdullahdevrel self-requested a review May 11, 2023 11:48
Copy link
Copy Markdown
Contributor

@abdullahdevrel abdullahdevrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect. I have added just one link as a marketing plug. I will create the granular level docs on the community

Comment thread README.md Outdated
@UmanShahzad
Copy link
Copy Markdown
Contributor

Do we have a linear ticket for the project? I will create a child ticket for myself.

@abdullahdevrel yeah we do, will DM it to you (this project will be public soon).

@rm-Umar rm-Umar requested a review from UmanShahzad May 12, 2023 05:32
Comment thread ipinfodb/client.py Outdated
@rm-Umar rm-Umar requested a review from UmanShahzad May 12, 2023 06:58
@UmanShahzad UmanShahzad merged commit f2dca83 into master May 12, 2023
@UmanShahzad UmanShahzad deleted the umar/initial-implementation branch May 12, 2023 08:57
@UmanShahzad
Copy link
Copy Markdown
Contributor

@rm-Umar When you get a chance, I think we can proceed with publishing and making this repo public too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants